Postgres Pro
Downloads
Home   >   mailing lists

Re: PQclientEncoding() returns -1, resulting in possible assertion failure in psql - Mailing list pgsql-bugs

From Tom Lane
Subject Re: PQclientEncoding() returns -1, resulting in possible assertion failure in psql
Date
Msg-id 19855.1395503953@sss.pgh.pa.us
Whole thread Raw
In response to Re: PQclientEncoding() returns -1, resulting in possible assertion failure in psql  (Bruce Momjian <bruce@momjian.us>)
List pgsql-bugs
Tree view 
Bruce Momjian <bruce@momjian.us> writes:
> Also, what is the difference between _PG_LAST_ENCODING_, which is the
> last encoding enum, and the pg_wchar_tbl length calculation?  Are they
> the same?

They certainly should be; I don't think it's the responsibility of these
functions to defend against them not being so.

> If so, we should just use _PG_LAST_ENCODING_.

Well, we should use PG_VALID_ENCODING() imo.

            regards, tom lane

pgsql-bugs by date:

Previous
From: Tom Lane
Date:
Subject: Re: PQclientEncoding() returns -1, resulting in possible assertion failure in psql
Next
From: Bruce Momjian
Date:
Subject: Re: PQclientEncoding() returns -1, resulting in possible assertion failure in psql