Re: Use correct collation in pg_trgm - Mailing list pgsql-hackers

From David Geier
Subject Re: Use correct collation in pg_trgm
Date
Msg-id 1981b5f0-7d06-4911-a231-23bbb6bf504c@gmail.com
Whole thread Raw
In response to Re: Use correct collation in pg_trgm  (Zsolt Parragi <zsolt.parragi@percona.com>)
Responses Re: Use correct collation in pg_trgm
List pgsql-hackers
Hi!

Thanks for reviewing.

On 22.01.2026 07:32, Zsolt Parragi wrote:
> Hello!
> 
> The patch is simple and it does what it says it does, I verified the
> difference in behavior with/without it.

While reading through [1] I realized that the word boundary detection
also uses the wrong collation. Patch 0002 fixes that.

> I think the test case included in the email should be part of the
> patch, maybe as a new file contrib/pg_trgm/sql/pg_trgm_collation.sql?
> It also needs a proper commit message, and seems like the affected
> indexes will need a REINDEX after this fix.

- I've added tests to 0001 and 0002 based on what each commit fixes.
- I've improved the commit messages.

Looking at [2], it seems like we don't include release note changes in
bug fix commits but rather collect them retroactively before cutting the
release.

[1]
https://www.postgresql.org/message-id/f30299bf-ad8e-4125-bf80-e0a8663991b6%40eisentraut.org

[2]
https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=fb1a18810f0

--
David Geier
Attachment

pgsql-hackers by date:

Previous
From: Álvaro Herrera
Date:
Subject: Re: Time to drop RADIUS support?
Next
From: Anthonin Bonnefoy
Date:
Subject: Auto-tune shared_buffers to use available huge pages