Re: [PATCH] Implement uuid_version() - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCH] Implement uuid_version()
Date
Msg-id 19808.1554568547@sss.pgh.pa.us
Whole thread Raw
In response to [PATCH] Implement uuid_version()  (Jose Luis Tallon <jltallon@adv-solutions.net>)
Responses Re: [PATCH] Implement uuid_version()
Re: [PATCH] Implement uuid_version()
List pgsql-hackers
Jose Luis Tallon <jltallon@adv-solutions.net> writes:
>      While working on an application, the need arose to be able 
> efficiently differentiate v4/v5 UUIDs (for use in partial indexes, among 
> others)
> ... so please find attached a trivial patch which adds the 
> functionality.

No particular objection...

>      I'm not sure whether this actually would justify a version bump for 
> the OSSP-UUID extension

Yes.  Basically, once we've shipped a given version of an extension's
SQL script, that version is *frozen*.  Anything at all that you want
to do to it has to be done in an extension update script, because
otherwise there's no clean migration path for users.

So basically, leave uuid-ossp--1.1.sql as it stands, and put the
new CREATE FUNCTION in a new uuid-ossp--1.1--1.2.sql script.
See any recent patch that updated an extension for an example, eg
commit eb6f29141bed9dc95cb473614c30f470ef980705.

(We do allow exceptions when somebody's already updated the extension
in the current devel cycle, but that doesn't apply here.)

> Another matter, which I'd like to propose in a later thread, is 
> whether it'd be interesting to include the main UUID functionality 
> directly in core

We've rejected that before, and I don't see any reason to think
the situation has changed since prior discussions.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Fabien COELHO
Date:
Subject: pgbench - extend initialization phase control
Next
From: Tom Lane
Date:
Subject: tableam scan-API patch broke foreign key validation