Re: [HACKERS] Supporting huge pages on Windows - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [HACKERS] Supporting huge pages on Windows
Date
Msg-id 19752.1516551119@sss.pgh.pa.us
Whole thread Raw
In response to Re: [HACKERS] Supporting huge pages on Windows  (Magnus Hagander <magnus@hagander.net>)
Responses Re: [HACKERS] Supporting huge pages on Windows
List pgsql-hackers
Magnus Hagander <magnus@hagander.net> writes:
> With that, I'm pushing this. Let's see what the buildfarm thinks of it. And
> if others end up complaining about the platform drop, but I doubt that.

frogmouth:

pg_shmem.c: In function 'PGSharedMemoryCreate':
pg_shmem.c:205:3: warning: implicit declaration of function 'GetLargePageMinimum'
pg_shmem.c:222:38: error: 'SEC_LARGE_PAGES' undeclared (first use in this function)
pg_shmem.c:222:38: note: each undeclared identifier is reported only once for each function it appears in
make[3]: *** [pg_shmem.o] Error 1

so you were right to guess that this functionality isn't in XP.

I wonder whether this could be band-aided around by using "#ifdef
SEC_LARGE_PAGES" to protect the new code.  I have no particular desire to
spend effort on supporting old Windows versions, but if there's someone
out there who does, they could be asked to look into that.

            regards, tom lane


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [HACKERS] Refactor handling of database attributes between pg_dump and pg_dumpall
Next
From: Magnus Hagander
Date:
Subject: Re: [HACKERS] Supporting huge pages on Windows