Re: Refactoring of command.c - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Refactoring of command.c
Date
Msg-id 19747.1014786197@sss.pgh.pa.us
Whole thread Raw
In response to Re: Refactoring of command.c  (Bruce Momjian <pgman@candle.pha.pa.us>)
List pgsql-hackers
Bruce Momjian <pgman@candle.pha.pa.us> writes:
> Peter Eisentraut wrote:
>> John Gray writes:
> dbcommands.c    rename to database.c (see below)
> indexcmds.c    rename to index.c (see below)
>> 
>> Might as well keep these.  They don't hurt anyone just because they spell
>> a little differently.

> I disagree.  If we are cleaning, let's clean.  *cmd* is redundant.  The
> contents of the files will be quite different anyway.

But if we rename them, we will lose CVS history for the files (unless we
jump through hoops that typically are not jumped through).  I agree with
Peter: do not rename files simply to have slightly simpler file names.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: Refactoring of command.c
Next
From: Tom Lane
Date:
Subject: Re: Rename sequence bug/feature