Re: alter_table regression test problem - Mailing list pgsql-hackers

From Tom Lane
Subject Re: alter_table regression test problem
Date
Msg-id 19658.1383836155@sss.pgh.pa.us
Whole thread Raw
In response to Re: alter_table regression test problem  (Kevin Grittner <kgrittn@ymail.com>)
Responses Re: alter_table regression test problem  (Andres Freund <andres@2ndquadrant.com>)
List pgsql-hackers
Kevin Grittner <kgrittn@ymail.com> writes:
> I think it is pretty much SOP for committers to prefer a patch that
> adds a new pair of braces around 50 lines of code and only changes
> non-whitespace of a few lines within that block to leave the block
> at its old indentation.

Yes.  It's much easier to review a patch done that way than to wonder if
the apparently-just-whitespace changes are masking something substantive.
In fact, if I'm reviewing a patch that reindents a big chunk of existing
code, I'll frequently not use the patch but reconstruct it that way,
just to be sure.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Kevin Grittner
Date:
Subject: Re: alter_table regression test problem
Next
From: Andres Freund
Date:
Subject: Re: alter_table regression test problem