Re: What is happening on buildfarm member dugong - Mailing list pgsql-hackers

From Tom Lane
Subject Re: What is happening on buildfarm member dugong
Date
Msg-id 19521.1189741888@sss.pgh.pa.us
Whole thread Raw
In response to Re: What is happening on buildfarm member dugong  ("Sergey E. Koposov" <math@sai.msu.ru>)
List pgsql-hackers
"Sergey E. Koposov" <math@sai.msu.ru> writes:
> It turned out that the offending assert is
> Assert(BgWriterShmem != NULL); in bgwriter.c:990
> After commenting it out everything works.

That's simply bizarre ...

> Also, I tried to add 'volatile' to the declaration of BgWriterShmem. After 
> that the problem disappears too.

Hm.  I don't see any very good reason in the code to add the "volatile",
and I see at least one place where we'd have to cast it away (the MemSet
at line 836).  My inclination is just to remove the Assert at line 990.
It's not proving anything, since if indeed BgWriterShmem was NULL there,
we'd dump core on the dereferences just a couple lines below.

Do you want this patched any further back than HEAD?  The buildfarm
status page doesn't show dugong doing any back branches ...
        regards, tom lane


pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: [mmoncure@gmail.com: Re: [GENERAL] array_to_set functions]
Next
From: Alvaro Herrera
Date:
Subject: Re: Reducing Transaction Start/End Contention