Re: Inserting heap tuples in bulk in COPY - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Inserting heap tuples in bulk in COPY
Date
Msg-id 19438.1313246033@sss.pgh.pa.us
Whole thread Raw
In response to Inserting heap tuples in bulk in COPY  (Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>)
Responses Re: Inserting heap tuples in bulk in COPY
List pgsql-hackers
Heikki Linnakangas <heikki.linnakangas@enterprisedb.com> writes:
> The patch is WIP, mainly because I didn't write the WAL replay routines 
> yet, but please let me know if you see any issues.

Why do you need new WAL replay routines?  Can't you just use the existing
XLOG_HEAP_NEWPAGE support?

By any large, I think we should be avoiding special-purpose WAL entries
as much as possible.

Also, I strongly object to turning regular heap_insert into a wrapper
around some other more complicated operation.  That will likely have
bad consequences for the performance of every other operation.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: VACUUM FULL versus system catalog cache invalidation
Next
From: Tom Lane
Date:
Subject: Re: VACUUM FULL versus system catalog cache invalidation