Re: Patch for Makefile race against current cvs - Mailing list pgsql-patches

From Tom Lane
Subject Re: Patch for Makefile race against current cvs
Date
Msg-id 19404.1005599609@sss.pgh.pa.us
Whole thread Raw
In response to Re: Patch for Makefile race against current cvs  (Peter Eisentraut <peter_e@gmx.net>)
Responses Re: Patch for Makefile race against current cvs
List pgsql-patches
Peter Eisentraut <peter_e@gmx.net> writes:
> Tom Lane writes:
>> But we could provide some security for multiple children of a single
>> make by changing the rules to be like
>>
>> $(srcdir)/parse.h: gram.y
>> ifdef YACC
>> $(YACC) -d $(YFLAGS) $<
>> mv y.tab.h $(srcdir)/parse.h
>> mv y.tab.c $(srcdir)/gram.c
>> else
>> @$(missing) bison $< $@
>> endif
>>
>> $(srcdir)/gram.c: $(srcdir)/parse.h

> That seems to be okay, although I think I'd switch gram.c and parse.h for
> stylistic reasons.

It's not real important, but I thought it would be a good idea to
minimize the dependencies seen by sub-makes entering the directory from
other backend directories.  Those sub-makes will only be interested in
parse.h, not in gram.c.

            regards, tom lane

pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: Patch for Makefile race against current cvs
Next
From: Bill Studenmund
Date:
Subject: Patch to add Heimdal kerberos support