Re: BUG #4869: No proper initialization of OpenSSL-Engine in libpq - Mailing list pgsql-bugs

From Tom Lane
Subject Re: BUG #4869: No proper initialization of OpenSSL-Engine in libpq
Date
Msg-id 19329.1245686712@sss.pgh.pa.us
Whole thread Raw
In response to Re: BUG #4869: No proper initialization of OpenSSL-Engine in libpq  (Magnus Hagander <magnus@hagander.net>)
Responses Re: BUG #4869: No proper initialization of OpenSSL-Engine in libpq  (Magnus Hagander <magnus@hagander.net>)
List pgsql-bugs
Magnus Hagander <magnus@hagander.net> writes:
> How about the attached patch? Does it work for you?

The existing references to typedef ENGINE and associated functions are
wrapped in

#if (SSLEAY_VERSION_NUMBER >= 0x00907000L) && !defined(OPENSSL_NO_ENGINE)

I rather imagine that this patch will cause complete failure in builds
where that's not true.  I'm also a bit concerned about wrapping a struct
field inside such an #if, as that's likely to cause hard-to-debug
problems if two compilations read libpq-int.h with different #define
environments.

            regards, tom lane

pgsql-bugs by date:

Previous
From: Tom Lane
Date:
Subject: Re: BUG #4869: No proper initialization of OpenSSL-Engine in libpq
Next
From: Magnus Hagander
Date:
Subject: Re: BUG #4869: No proper initialization of OpenSSL-Engine in libpq