Re: pg_dump -Ft failed on Windows XP - Mailing list pgsql-hackers

From Tom Lane
Subject Re: pg_dump -Ft failed on Windows XP
Date
Msg-id 19296.1145549256@sss.pgh.pa.us
Whole thread Raw
In response to Re: pg_dump -Ft failed on Windows XP  ("Magnus Hagander" <mha@sollentuna.net>)
List pgsql-hackers
"Magnus Hagander" <mha@sollentuna.net> writes:
> Ok. Should be easy enough once the code is fine - can you comment on the
> patch as sent, if the code itself looks right provided i wrap it up in a
> function in port/?

Not sure if the error handling is adequate --- are there any cases
besides EEXIST that should loop?

A look at

http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vclib/html/_crt__tempnam.2c_._wtempnam.2c_.tmpnam.2c_._wtmpnam.asp

suggests that tempnam() is also pretty fragile, esp. if you're passing
NULLs.  Apparently it won't work at all if TMP isn't set?
        regards, tom lane


pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: float8 regression test failure in head
Next
From: Patrick Welche
Date:
Subject: Re: float8 regression test failure in head