Jonathan Rogers <jrogers@socialserve.com> writes:
> Would it be better to move clone_file() into its own module where
> implementations for other file system types might eventually be added?
Yeah, possibly. I considered suggesting that the current code be
treated as a fallback implementation of clone_file, but I'm not sure
if there's a convenient way to manage the run-time fallback if we try
to do it like that. In any case, +1 for leaving the door open for
easy addition of other cloning techniques.
regards, tom lane
