Re: Thoughts about bug #3883 - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Thoughts about bug #3883
Date
Msg-id 19175.1201295785@sss.pgh.pa.us
Whole thread Raw
In response to Re: Thoughts about bug #3883  (Gregory Stark <stark@enterprisedb.com>)
List pgsql-hackers
Gregory Stark <stark@enterprisedb.com> writes:
> "Tom Lane" <tgl@sss.pgh.pa.us> writes:
>> The simplest fix seems to be to invent an additional flag variable
>> "signalAwaited" which is set/cleared by ProcWaitForSignal and checked by
>> LockWaitCancel. This would make cancelling out of a ProcWaitForSignal call
>> exactly analogous to cancelling out of a heavyweight-lock acquisition.

> Is that the flag that is an assertion that no cleanup is needed? Or is that
> something else?

No, the problem is merely to get LockWaitCancel to return "true" so that
StatementCancelHandler will go ahead with the immediate interrupt.  No
new cleanup is needed other than resetting the new flag.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Gregory Stark
Date:
Subject: Re: Truncate Triggers
Next
From: Simon Riggs
Date:
Subject: Re: Proposal: Integrity check