Re: Google SoC--Idea Request - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Google SoC--Idea Request
Date
Msg-id 19168.1145548592@sss.pgh.pa.us
Whole thread Raw
In response to Re: Google SoC--Idea Request  (Martijn van Oosterhout <kleptog@svana.org>)
Responses Re: Google SoC--Idea Request  (Martijn van Oosterhout <kleptog@svana.org>)
List pgsql-hackers
Martijn van Oosterhout <kleptog@svana.org> writes:
> About the only thing in the backend I found interesting was this:
> src/backend/utils/hash/dynahash.c function hash_create

I wonder if we shouldn't just remove the hash_destroy calls in
hash_create's failure paths.  hash_destroy is explicitly not gonna
work on a shared-memory hashtable, and in all other cases I'd expect
that any already-allocated table structure will be in a palloc context
that will get cleaned up during error recovery.
        regards, tom lane


pgsql-hackers by date:

Previous
From: "Magnus Hagander"
Date:
Subject: Re: pg_dump -Ft failed on Windows XP
Next
From: Bruce Momjian
Date:
Subject: Re: float8 regression test failure in head