Re: Add support for SRF and returning composites to pl/tcl - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Add support for SRF and returning composites to pl/tcl
Date
Msg-id 19165.1478615614@sss.pgh.pa.us
Whole thread Raw
In response to Re: Add support for SRF and returning composites to pl/tcl  (Jim Nasby <Jim.Nasby@BlueTreble.com>)
Responses Re: Add support for SRF and returning composites to pl/tcl  (Jim Nasby <Jim.Nasby@BlueTreble.com>)
List pgsql-hackers
Jim Nasby <Jim.Nasby@bluetreble.com> writes:
> Hrm, I completely spaced on the fact that composite returns are 
> essentially the same thing as trigger returns. ISTM we should be able to 
> use the same code for both. IIRC those magic elements could end up in 
> any SPI result, so that handling certainly needs to be the same.

> Have you had a chance to look at this or should I?

As things stand in HEAD, the behavior is about the same, but the error
messages are not --- in one case they mention triggers and of course the
other doesn't.  There are a couple of other minor things in the way of
unifying the two hunks of code, so I concluded it probably wasn't worth
the trouble.  But feel free to take another look if it bugs you.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Jim Nasby
Date:
Subject: Re: C based plugins, clocks, locks, and configuration variables
Next
From: Tom Lane
Date:
Subject: Re: Fix bug in handling of dropped columns in pltcl triggers