Re: GiST buffering build, bug in levelStep calculation - Mailing list pgsql-hackers

From Tom Lane
Subject Re: GiST buffering build, bug in levelStep calculation
Date
Msg-id 19058.1338323102@sss.pgh.pa.us
Whole thread Raw
In response to Re: GiST buffering build, bug in levelStep calculation  (Alexander Korotkov <aekorotkov@gmail.com>)
Responses Re: GiST buffering build, bug in levelStep calculation
List pgsql-hackers
Alexander Korotkov <aekorotkov@gmail.com> writes:
> On Tue, May 29, 2012 at 11:42 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> While I'm looking at this, is the first test involving
>> effective_cache_size bulletproof either?  In particular, is
>> avgIndexTuplesPerPage clamped to be strictly greater than 1?

> It's based on collected statistics on already inserted tuple sizes. Since
> tuple sizes are measured after possible toasting, I don't see the way
> for avgIndexTuplesPerPage to be less than 1.

Yeah, but if it could be *equal* to one, you've got a zero-divide there.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Alexander Korotkov
Date:
Subject: Re: GiST buffering build, bug in levelStep calculation
Next
From: Magnus Hagander
Date:
Subject: Re: pg_basebackup --xlog compatibility break