Re: [PATCH] expand the units that pg_size_pretty supports on output - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCH] expand the units that pg_size_pretty supports on output
Date
Msg-id 1903029.1625686260@sss.pgh.pa.us
Whole thread Raw
In response to Re: [PATCH] expand the units that pg_size_pretty supports on output  (David Christensen <david.christensen@crunchydata.com>)
Responses Re: [PATCH] expand the units that pg_size_pretty supports on output  (David Christensen <david.christensen@crunchydata.com>)
Re: [PATCH] expand the units that pg_size_pretty supports on output  (David Rowley <dgrowleyml@gmail.com>)
List pgsql-hackers
David Christensen <david.christensen@crunchydata.com> writes:
> Enclosed is the patch to change the return type to numeric, as well as one for expanding units to
> add PB and EB.

Can we really get away with changing the return type?  That would
by no stretch of the imagination be free; one could expect breakage
of a few user views, for example.

Independently of that, I'm pretty much -1 on going further than PB.
Even if the additional abbreviations you mention are actually recognized
standards, I think not that many people are familiar with them, and such
input is way more likely to be a typo than intended data.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: PostgreSQL 14 backend crash on incorrect trigger
Next
From: David Christensen
Date:
Subject: Re: [PATCH] expand the units that pg_size_pretty supports on output