Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH v2] src/port/snprintf.c: Optimize the common base=10 case in fmtint - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCH v2] src/port/snprintf.c: Optimize the common base=10 case in fmtint
Date
Msg-id 190223.1635298794@sss.pgh.pa.us
Whole thread Raw
In response to Re: [PATCH v2] src/port/snprintf.c: Optimize the common base=10 case in fmtint  (Japin Li <japinli@hotmail.com>)
Responses Re: [PATCH v2] src/port/snprintf.c: Optimize the common base=10 case in fmtint  (Arjan van de Ven <arjan@linux.intel.com>)
List pgsql-hackers
Tree view 
Japin Li <japinli@hotmail.com> writes:
> Why do we need likely() for base=10, however, base=16 and base=8 don't need?

Yeah, I was a little unconvinced about that too.  I concur with writing
it as an if/else chain instead of a switch, but I'm not sure that likely()
adds anything to that.

            regards, tom lane

pgsql-hackers by date:

Previous
From: Japin Li
Date:
Subject: Re: [PATCH v2] src/port/snprintf.c: Optimize the common base=10 case in fmtint
Next
From: Japin Li
Date:
Subject: Re: [Bug] Logical Replication failing if the DateStyle is different in Publisher & Subscriber