Re: VACUUM fails to parse 0 and 1 as boolean value - Mailing list pgsql-hackers

From Tom Lane
Subject Re: VACUUM fails to parse 0 and 1 as boolean value
Date
Msg-id 19013.1558446022@sss.pgh.pa.us
Whole thread Raw
In response to Re: VACUUM fails to parse 0 and 1 as boolean value  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
Michael Paquier <michael@paquier.xyz> writes:
> On Mon, May 20, 2019 at 09:55:59AM -0400, Robert Haas wrote:
>> Well, it's confusing that we're not consistent about which spellings
>> are accepted.  The GUC system accepts true/false, on/off, and 0/1, so
>> it seems reasonable to me to standardize on that treatment across the
>> board.  That's not necessarily something we have to do for v12, but
>> longer-term, consistency is of value.

> +1.

> Note: boolean GUCs accept a bit more: yes, no, tr, fa, and their upper
> case flavors, etc.  These are everything parse_bool():bool.c accepts
> as valid values.

I'm not excited about allowing abbreviated keywords here, though.
Allowing true/false, on/off, and 0/1 seems reasonable but let's
not go overboard.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: A few more opportunities to use TupleTableSlotOps fields
Next
From: Peter Eisentraut
Date:
Subject: Re: PG 12 draft release notes