Re: Add bms_offset_members() function for bitshifting Bitmapsets - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Add bms_offset_members() function for bitshifting Bitmapsets
Date
Msg-id 1900289.1776212948@sss.pgh.pa.us
Whole thread
In response to Re: Add bms_offset_members() function for bitshifting Bitmapsets  (David Rowley <dgrowleyml@gmail.com>)
Responses Re: Add bms_offset_members() function for bitshifting Bitmapsets
List pgsql-hackers
David Rowley <dgrowleyml@gmail.com> writes:
> Your idea of checking the old highest member plus the offset seems a
> more robust method, so I've adjusted the patch to use that.

I question the decision to make this change the set in-place.
Wouldn't it be cheaper and less surprise-prone to always make
a copy?

            regards, tom lane



pgsql-hackers by date:

Previous
From: David Rowley
Date:
Subject: Re: Add bms_offset_members() function for bitshifting Bitmapsets
Next
From: Michael Paquier
Date:
Subject: Re: [PATCH] Miscellaneous little fixes