Re: [Bug Fix] ECPG: could not use set xxx to default statement - Mailing list pgsql-hackers

From Michael Meskes
Subject Re: [Bug Fix] ECPG: could not use set xxx to default statement
Date
Msg-id 189edd214c2b216f6d3fde594115089fdcbed0f6.camel@postgresql.org
Whole thread Raw
In response to Re: [Bug Fix] ECPG: could not use set xxx to default statement  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [Bug Fix] ECPG: could not use set xxx to default statement  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
> Not seeing any motion on this, here's a draft patch to make these
> scripts complain about missing semicolons.  Against the current
> gram.y (which contains 2 such errors, as Michael noted) you
> get output like

Thanks Tom for looking into this. Are we agreed then that we want
gram.y to have semicolons? 

> '/usr/bin/perl' ./parse.pl . < ../../../backend/parser/gram.y >
> preproc.y
> unterminated rule at ./parse.pl line 370, <> line 1469.
> make: *** [preproc.y] Error 255
> make: *** Deleting file `preproc.y'
> 
> That's not *super* friendly, but it does give you the right line
> number
> to look at in gram.y.  We could adjust the script (and the Makefile)
> further so that the message would cite the gram.y filename, but I'm
> not
> sure if it's worth the trouble.  Thoughts?

IMO it's not worth it. We all know where the grammar is and that the
ecpg tools only parse that one file. Why putting effort into writing it
down too?

Michael
-- 
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Meskes at (Debian|Postgresql) dot Org
Jabber: michael at xmpp dot meskes dot org
VfL Borussia! Força Barça! SF 49ers! Use Debian GNU/Linux, PostgreSQL



pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: [PATCH v20] GSSAPI encryption support
Next
From: Haribabu Kommi
Date:
Subject: Re: [HACKERS] Block level parallel vacuum