Peter Eisentraut <peter_e@gmx.net> writes:
> Jeff Davis writes:
>> *Convert remaining fprintf(stderr,...)/perror() to elog()
> This isn't quite as easy as a mechanical conversion, mind you, because
> elog of course has rather complex side effects besides printing out a
> message.
AFAIR, elog at NOTICE or DEBUG level isn't really supposed to have any
side-effects. The bigger issue is that you have to be careful about
using it in certain places, mainly during startup or for reporting
communication errors. (send failure -> elog -> tries to send message to
client -> send failure -> elog -> trouble)
Also, I believe most of the printf's in the backend are in debugging
support code that's not even compiled by default. The return on
investment from converting those routines to use elog is really nil.
There may be a few remaining printf calls that should be converted to
elog, but I don't think this is a big issue.
regards, tom lane
