Re: Rethinking the implementation of ts_headline() - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Rethinking the implementation of ts_headline()
Date
Msg-id 1881797.1673886532@sss.pgh.pa.us
Whole thread Raw
In response to Re: Rethinking the implementation of ts_headline()  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
Responses Re: Rethinking the implementation of ts_headline()
List pgsql-hackers
Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> I came across #17556 which contains a different test for this, and I'm
> not sure that this patch changes things completely for the better.

Thanks for looking at my patch.  However ...

> That is, once past the 5000 words of distance, it fails to find a good
> cover, but before that it returns an acceptable headline.  However,
> after your proposed patch, we get this:

>  ts_headline │ ts_headline
> ─────────────┼─────────────
>  {ipsum}     │ {ipsum}
> (1 fila)

I get this with the patch:

     ts_headline     |     ts_headline
---------------------+---------------------
 {ipsum} ... {labor} | {ipsum} ... {labor}
(1 row)

which is what I'd expect, because it removes the artificial limit on
cover length that I added in 78e73e875.  So I'm wondering why you got a
different result.  Maybe something to do with locale?  I tried it in
C and en_US.utf8.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Ashutosh Bapat
Date:
Subject: Re: Logical replication timeout problem
Next
From: Tomas Vondra
Date:
Subject: Re: Perform streaming logical transactions by background workers and parallel apply