Re: recovery test failures on hoverfly - Mailing list pgsql-hackers

From Tom Lane
Subject Re: recovery test failures on hoverfly
Date
Msg-id 1880199.1623422241@sss.pgh.pa.us
Whole thread Raw
In response to Re: recovery test failures on hoverfly  (Michael Paquier <michael@paquier.xyz>)
Responses Re: recovery test failures on hoverfly
List pgsql-hackers
Michael Paquier <michael@paquier.xyz> writes:
> On Fri, Jun 11, 2021 at 05:38:34PM +0530, Amit Kapila wrote:
>> It seems the error happens in both the tests when after issuing a
>> KILL, we are trying to reconnect. Can we do anything for this?

> This is the same problem as c757a3da and 6d41dd0, where we write a
> query to a pipe but the kill, causing a failure, makes the test fail
> with a SIGPIPE in IPC::Run as a query is sent down to a pipe.

Indeed.

> I think that using SELECT 1 to test if the server has been restarted
> is a bit crazy.  I would suggest to use instead a loop based on
> pg_isready.

The precedent of the previous fixes would seem to suggest seeing if
we can replace 'SELECT 1' with "undef".  Not sure if that'll work
without annoying changes to poll_query_until, though.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Fabien COELHO
Date:
Subject: Re: Error on pgbench logs
Next
From: Tom Lane
Date:
Subject: Re: Race condition in recovery?