Re: ALTER TABLE...ALTER COLUMN vs inheritance - Mailing list pgsql-hackers

From Tom Lane
Subject Re: ALTER TABLE...ALTER COLUMN vs inheritance
Date
Msg-id 18798.1258067245@sss.pgh.pa.us
Whole thread Raw
In response to Re: ALTER TABLE...ALTER COLUMN vs inheritance  (Alex Hunsaker <badalex@gmail.com>)
List pgsql-hackers
Alex Hunsaker <badalex@gmail.com> writes:
> On Thu, Nov 12, 2009 at 13:55, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> I'd go for the first of those, for sure.  Testing attnotnull is
>> significantly cheaper than enforcing a generic constraint expression,
>> and NOT NULL is a sufficiently common case to be worth worrying about
>> optimizing it.

> When I looked at doing this, I thought about just using check
> constraints just for the book keeping and leaving attnotnull as it is.

Yeah, you could definitely attack it like that.  The code that fixes up
attnotnull would have to look for check constraints that look like "foo
NOT NULL" rather than something more instantly recognizable, but
presumably ALTER TABLE is not a performance-critical path.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Alex Hunsaker
Date:
Subject: Re: ALTER TABLE...ALTER COLUMN vs inheritance
Next
From: Alvaro Herrera
Date:
Subject: Re: actualised funcs typmod patch