Re: Fix some corner cases that cube_in rejects - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Fix some corner cases that cube_in rejects
Date
Msg-id 18779.1472500458@sss.pgh.pa.us
Whole thread Raw
In response to Re: Fix some corner cases that cube_in rejects  (Greg Stark <stark@mit.edu>)
Responses Re: Fix some corner cases that cube_in rejects  (Amul Sul <sulamul@gmail.com>)
List pgsql-hackers
Greg Stark <stark@mit.edu> writes:
> On Mon, Aug 29, 2016 at 7:19 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> To deal with the infinity/NaN issues, I made cube_in and cube_out rely
>> on float8in_internal and float8out_internal, as we recently did for the
>> core geometric types.  That causes the response to "1e-700" to be an
>> out-of-range error rather than silent underflow, which seems to me to
>> be fine, especially since it removes the platform dependency that's
>> responsible for needing the separate cube_1.out and cube_3.out files.

> So what happens to a database that has invalid cubes in it already?
> Offhand I suspect they mostly become valid since float8in will handle
> NaN and the like.

Nothing really.  cube_out works fine.  The point of substituting
float8out_internal is mostly to make sure we get platform-independent
spellings for inf and nan.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Greg Stark
Date:
Subject: Re: Fix some corner cases that cube_in rejects
Next
From: Martín Marqués
Date:
Subject: Re: pg_dump with tables created in schemas created by extensions