Re: Add PortalDrop in exec_execute_message - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Add PortalDrop in exec_execute_message
Date
Msg-id 1875433.1623418705@sss.pgh.pa.us
Whole thread Raw
In response to Re: Add PortalDrop in exec_execute_message  (Yura Sokolov <y.sokolov@postgrespro.ru>)
List pgsql-hackers
Yura Sokolov <y.sokolov@postgrespro.ru> writes:
> This makes me think, Close message were intended to be used
> but simply forgotten when libpq patch were made.
> Tom, could I be right?

You could argue all day about what the intentions were nearly twenty
years ago.  But the facts on the ground are that we don't issue Close
in those places, and changing it now would be a de facto protocol
change for applications.  So I'm a hard -1 on these proposals.

(Alvaro's proposed change isn't a protocol break, since pipeline
mode hasn't shipped yet.  It's trying to make some brand new code
act more like old code, which seems like a fine idea.)

I think that the actual problem here has been resolved in
commit bb4aed46a.  Perhaps we should reconsider my decision not to
back-patch that.  Unlike a protocol change, that one could possibly
be sane to back-patch.  I didn't think it was worth the trouble and
risk, but maybe there's a case for it.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Bharath Rupireddy
Date:
Subject: Re: Added schema level support for publication.
Next
From: Amit Kapila
Date:
Subject: Re: Decoding speculative insert with toast leaks memory