Re: improve performance of pg_dump with many sequences - Mailing list pgsql-hackers

From Tom Lane
Subject Re: improve performance of pg_dump with many sequences
Date
Msg-id 1862355.1767827628@sss.pgh.pa.us
Whole thread Raw
In response to Re: improve performance of pg_dump with many sequences  (Nathan Bossart <nathandbossart@gmail.com>)
Responses Re: improve performance of pg_dump with many sequences
List pgsql-hackers
Nathan Bossart <nathandbossart@gmail.com> writes:
> Before v18, pg_dump just ERRORs due to insufficient privileges on a
> sequence.  IMHO that makes sense.  If you ask pg_dump to dump something you
> don't have privileges on, I'd expect it to error instead of silently
> skipping it.

That would be a fine argument were it not that collectSequences()
tries to vacuum up the data for every sequence in the DB, whether
the user has asked to dump them all or not.  In other places in
pg_dump, we avoid such problems by restricting which tables we
ask for data about ... but not here.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Robert Treat
Date:
Subject: Re: DOC: fixes multiple errors in alter table doc
Next
From: Chao Li
Date:
Subject: Re: nbtree: Cache operator family OID in _bt_setup_array_cmp