Re: Out of Memory errors are frustrating as heck! - Mailing list pgsql-performance

From Tom Lane
Subject Re: Out of Memory errors are frustrating as heck!
Date
Msg-id 18440.1555350300@sss.pgh.pa.us
Whole thread Raw
In response to Re: Out of Memory errors are frustrating as heck!  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-performance
Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> Seems that ExecHashJoinGetSavedTuple stores a minimalTuple and sets the
> shouldFree flag to "true", and then in ExecHashJoinNewBatch, callee
> ExecFetchSlotMinimalTuple sets shouldFree to false inconditionally when
> the slot uses minimal tuple ops.  Maybe that's correct, but it does
> sound like a memory leak is not entirely impossible.  I wonder if this
> fixes it, without causing crashes elsewhere.

This discussion is about v11, not HEAD.  Still, I agree that that
coding in HEAD seems a bit fishy.

            regards, tom lane



pgsql-performance by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: Out of Memory errors are frustrating as heck!
Next
From: Jeff Janes
Date:
Subject: Re: Out of Memory errors are frustrating as heck!