Re: Function to get invalidation cause of a replication slot. - Mailing list pgsql-hackers

Hi,

On 12/20/23 10:55 AM, shveta malik wrote:
> On Wed, Dec 20, 2023 at 2:20 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
> 
> 
> PFA v2 patch. Addressed below comments:
> 
> 1) Added test in 019_replslot_limit.pl
> 2) 'pg_get_slot_invalidation_cause' now returns error if the given
> slot does not exist
> 3) Corrected doc and commit msg.

Thanks!

+           <literal>3</literal> = wal_level insufficient on the primary server

"." is missing at the end (to be consistent with 1 and 2). Same
in the commit message.

+ * Returns ReplicationSlotInvalidationCause enum value for valid slot_name;

Not sure the sentence should finish with ";".

Another Nit is to add a comment in ReplicationSlotInvalidationCause definition (slot.h)
that any new enum values (if any) should be added after the ones that are already defined (to
provide some consistency across changes in this area if any).

Except the above Nit(s) the patch LGTM.

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com