Re: BUG #19056: ExecInitPartitionExecPruning segfault due to NULL es_part_prune_infos - Mailing list pgsql-bugs

From Tom Lane
Subject Re: BUG #19056: ExecInitPartitionExecPruning segfault due to NULL es_part_prune_infos
Date
Msg-id 1836971.1758168660@sss.pgh.pa.us
Whole thread Raw
In response to Re: BUG #19056: ExecInitPartitionExecPruning segfault due to NULL es_part_prune_infos  (David Rowley <dgrowleyml@gmail.com>)
Responses Re: BUG #19056: ExecInitPartitionExecPruning segfault due to NULL es_part_prune_infos
Re: BUG #19056: ExecInitPartitionExecPruning segfault due to NULL es_part_prune_infos
List pgsql-bugs
David Rowley <dgrowleyml@gmail.com> writes:
> On Thu, 18 Sept 2025 at 15:37, Amit Langote <amitlangote09@gmail.com> wrote:
>> +# Test that EState.es_part_prune_infos is properly set in EvalPlanQualStart()
>> +# Bug #19056

> I don't think it's that useful to note down the bug number that caused
> that test to be added.

We're inconsistent about whether we do that or not, but it's
far from un-heard-of.  I just today pushed a patch in which
I did mention the bug# in the test case [1], and I did so
mostly because the adjacent test case had a similar comment.
So I see no reason to object to Amit's usage.

> I think it'd be better to write something like:
> "Exercise run-time partition pruning code in an EPQ plan"

Not expressing an opinion about whether that's better or
worse than Amit's lede.

            regards, tom lane

[1] https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=b0cc0a71e0a0a760f54c72edb8cd000e4555442b



pgsql-bugs by date:

Previous
From: David Rowley
Date:
Subject: Re: BUG #19056: ExecInitPartitionExecPruning segfault due to NULL es_part_prune_infos
Next
From: Zane Duffield
Date:
Subject: Re: Lock timeouts and unusual spikes in replication lag with logical parallel transaction streaming