Re: getopt() and strdup() - Mailing list pgsql-hackers

From Tom Lane
Subject Re: getopt() and strdup()
Date
Msg-id 18243.1350155649@sss.pgh.pa.us
Whole thread Raw
In response to Re: getopt() and strdup()  (Phil Sorber <phil@omniti.com>)
Responses Re: getopt() and strdup()  (Phil Sorber <phil@omniti.com>)
List pgsql-hackers
Phil Sorber <phil@omniti.com> writes:
> On Wed, Oct 10, 2012 at 7:54 PM, Bruce Momjian <bruce@momjian.us> wrote:
>> Also, do we want to centralize the definition of pg_strdup() in /port,
>> or leave each module to define it on its own?

> +1 for a centralized definition.

The difficulty with a centralized definition is that it's not clear that
the error path is or should be *exactly* the same for all these usages.
I see at least six variants right now.  While some are gratuitous,
some of them are tied into local conventions of each program.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: Adding comments for system table/column names
Next
From: Magnus Hagander
Date:
Subject: Re: Adding comments for system table/column names