Re: mapping object names to role IDs - Mailing list pgsql-hackers

From Tom Lane
Subject Re: mapping object names to role IDs
Date
Msg-id 18218.1274638640@sss.pgh.pa.us
Whole thread Raw
In response to Re: mapping object names to role IDs  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
Robert Haas <robertmhaas@gmail.com> writes:
> Not every object type has a file, and the existing functions are split
> across three different directories, sometimes in files that don't
> really pertain to the object type being dealt with.  I think this is
> going to be difficult to maintain if we intentionally spread out the
> parallel code across essentially the entire backend.  But I guess I
> can code it up and we can argue about it then.

The only thing that seems really significantly parallel is the error
message to be issued for object-not-found.  I would suggest maybe
putting the code in lsyscache.c, except that lsyscache functions
generally are not expected to throw error on object-not-found.

As for "not every object type has a file", there is certainly code
someplace that would be calling these functions.  Whereever (the
preponderance of) such calls are would be an appropriate place for the
function, IMO.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: mapping object names to role IDs
Next
From: Jan Wieck
Date:
Subject: Exposing the Xact commit order to the user