Re: Default make target in test modules - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Default make target in test modules
Date
Msg-id 18169.1473353531@sss.pgh.pa.us
Whole thread Raw
In response to Re: Default make target in test modules  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Responses Re: Default make target in test modules  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Re: Default make target in test modules  (Stephen Frost <sfrost@snowman.net>)
List pgsql-hackers
Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> Tom Lane wrote:
>> I happened to notice that if you type "make" in
>> src/test/modules/test_pg_dump, you will get a "make check" action
>> not "make all".

> Strange.  Don't all these makefiles depend on the pgxs stuff emitting
> something sane, which would have "all" as the first one? ...  Ooh, I see
> that test_pg_dump adds "check" before including pgxs, which is what
> AFAICS causes the problem.

Right.

> I suppose this is a very easy mistake to make -- but also fortunately an
> easy one to correct.  Do you want me to fix the affected modules?

I was going to do it, but if you want to, feel free.

(BTW, I notice that test_pg_dump's Makefile misquotes its own path name,
probably copy-paste sloppiness.)
        regards, tom lane



pgsql-hackers by date:

Previous
From: Pavan Deolasee
Date:
Subject: Re: Vacuum: allow usage of more than 1GB of work mem
Next
From: Ashutosh Bapat
Date:
Subject: Re: Aggregate Push Down - Performing aggregation on foreign server