Re: [COMMITTERS] pgsql: Introduce dynamic shared memory areas. - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [COMMITTERS] pgsql: Introduce dynamic shared memory areas.
Date
Msg-id 18166.1480955837@sss.pgh.pa.us
Whole thread Raw
In response to Re: [COMMITTERS] pgsql: Introduce dynamic shared memory areas.  (Michael Paquier <michael.paquier@gmail.com>)
Responses Re: [COMMITTERS] pgsql: Introduce dynamic shared memory areas.  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
>> Introduce dynamic shared memory areas.

gaur finds another problem with dsa.c: it uses SIZE_MAX which AFAICS
is not required to exist by POSIX.

We could adopt the timezone code's workaround

#ifndef SIZE_MAX
#define SIZE_MAX ((size_t) -1)
#endif

but I don't find that particularly nice, and in any case I wonder
why we would want to use SIZE_MAX and not MaxAllocHugeSize.  The
overflow hazards that motivate that not being the max possible
value seem relevant here too.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Hash Indexes
Next
From: Andrew Dunstan
Date:
Subject: Re: Time to retire Windows XP buildfarm host?