Re: [BUGS] BUG #14849: jsonb_build_object doesn't like VARIADIC calls very much - Mailing list pgsql-bugs

From Tom Lane
Subject Re: [BUGS] BUG #14849: jsonb_build_object doesn't like VARIADIC calls very much
Date
Msg-id 18157.1508600622@sss.pgh.pa.us
Whole thread Raw
In response to Re: [BUGS] BUG #14849: jsonb_build_object doesn't like VARIADIC callsvery much  (Michael Paquier <michael.paquier@gmail.com>)
Responses Re: [BUGS] BUG #14849: jsonb_build_object doesn't like VARIADIC callsvery much
Re: [BUGS] BUG #14849: jsonb_build_object doesn't like VARIADIC callsvery much
List pgsql-bugs
Michael Paquier <michael.paquier@gmail.com> writes:
> Here you go, down to 9.4 where things apply. The same patch can be
> applied for HEAD/10, 9.5/9.6 and 9.4. The 9.4 version just needs to
> have the portion for json as the jsonb functions have been added in
> 9.5, and the json functions are new as of 9.4.

It doesn't seem very nice to have two identical(?) copies of 
extract_variadic_args, especially since the same functionality
might be of use elsewhere.  I'm almost inclined to say that that
should go in funcapi.c/.h.
        regards, tom lane


-- 
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs

pgsql-bugs by date:

Previous
From: Michael Paquier
Date:
Subject: Re: [BUGS] BUG #14849: jsonb_build_object doesn't like VARIADIC callsvery much
Next
From: Michael Paquier
Date:
Subject: Re: [BUGS] BUG #14849: jsonb_build_object doesn't like VARIADIC callsvery much