Re: fix windows contrib compile warnings for redefined macros - Mailing list pgsql-patches

From Tom Lane
Subject Re: fix windows contrib compile warnings for redefined macros
Date
Msg-id 18114.1098381882@sss.pgh.pa.us
Whole thread Raw
In response to fix windows contrib compile warnings for redefined macros  (Andrew Dunstan <andrew@dunslane.net>)
Responses Re: fix windows contrib compile warnings for redefined
List pgsql-patches
Andrew Dunstan <andrew@dunslane.net> writes:
> This patch fixes contrib so that it compiles under windows without
> warnings about redefines for min, max, V_UNKNOWN and IDIGNORE

Surely this is wrong.  You might be able to assume that Windows'
definitions for min/max are the same as what this code is expecting,
but it's a lot bigger stretch to assume that for the other ones.
(Does tsearch2 still *work* after you change it this way??)

The right thing for the min/max macros is to get rid of them anyway,
and use the Min/Max macros from c.h.

            regards, tom lane

pgsql-patches by date:

Previous
From: Andrew Dunstan
Date:
Subject: fix windows contrib compile warnings for redefined macros
Next
From: Andrew Dunstan
Date:
Subject: Re: fix windows contrib compile warnings for redefined