Re: [HACKERS] Re: [COMMITTERS] 'pgsql/src/backend/storage/buffer bufmgr.c' - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [HACKERS] Re: [COMMITTERS] 'pgsql/src/backend/storage/buffer bufmgr.c'
Date
Msg-id 18094.927990184@sss.pgh.pa.us
Whole thread Raw
In response to Re: [COMMITTERS] 'pgsql/src/backend/storage/buffer bufmgr.c'  (Vadim Mikheev <vadim@krs.ru>)
Responses Re: [HACKERS] Re: [COMMITTERS] 'pgsql/src/backend/storage/buffer bufmgr.c'  (The Hermit Hacker <scrappy@hub.org>)
List pgsql-hackers
Vadim Mikheev <vadim@krs.ru> writes:
>> bufmgr.c
>> Log Message:
>> Missing semicolons in non-HAS_TEST_AND_SET code paths :-(

> Thanks, Tom!
> I must say that I never tested non-Has_TEST_AND_SET case.

I haven't either --- but those two places stuck out like sore thumbs
after the pgindent run...

This suggests that none of the beta-testing group uses a machine that
doesn't have TEST_AND_SET support.  I suppose that's good news about the
coverage of s_lock.h, but it makes me worry that the non-TEST_AND_SET
code hasn't even been compiled, let alone exercised.  Someone ought to
build and test a copy with TEST_AND_SET deliberately removed from the
port.h file.
        regards, tom lane


pgsql-hackers by date:

Previous
From: "D'Arcy" "J.M." Cain
Date:
Subject: Re: [HACKERS] Open 6.5 items
Next
From: Tom Lane
Date:
Subject: Re: [HACKERS] Open 6.5 items