Re: Splitting lengthy sgml files - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Splitting lengthy sgml files
Date
Msg-id 18090.1457363397@sss.pgh.pa.us
Whole thread Raw
In response to Splitting lengthy sgml files  (Tatsuo Ishii <ishii@postgresql.org>)
Responses Re: Splitting lengthy sgml files
Re: Splitting lengthy sgml files
List pgsql-hackers
Tatsuo Ishii <ishii@postgresql.org> writes:
> There are very lengthy (over 10k lines, for example) SGML files in
> docs. While working on translating docs using GitHub, I noticed that
> sometimes diffs are not showed in pull requests due to the limitation
> of GitHub, which makes me pretty difficult to review PR. Any chance to
> split those lengthy SGML files into smaller SGML files?

Surely that's a github bug that you should be complaining to them about?

I'm disinclined to split existing files because (a) it would complicate
back-patching and (b) it would be completely destructive to git history.
git claims to understand about file moves but it doesn't do a terribly
good job with that history-wise (try git log or git blame on
recently-moved files such as pgbench).  And I've never heard even
a claim that it understands splits.

There might be reasons to override those disadvantages and do it
anyway ... but this doesn't sound like a very good reason.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Is there a way around function search_path killing SQL function inlining?
Next
From: Kevin Grittner
Date:
Subject: Re: The plan for FDW-based sharding