Re: 15beta1 tab completion of extension versions - Mailing list pgsql-hackers

From Tom Lane
Subject Re: 15beta1 tab completion of extension versions
Date
Msg-id 1803867.1655596168@sss.pgh.pa.us
Whole thread Raw
In response to 15beta1 tab completion of extension versions  (Jeff Janes <jeff.janes@gmail.com>)
Responses Re: 15beta1 tab completion of extension versions
List pgsql-hackers
Jeff Janes <jeff.janes@gmail.com> writes:
> Extension version strings need to be quoted.  Either double or single
> quotes will work.  In released psql clients, tab completion offers double
> quoted suggestions:
> But commit 02b8048ba5 broke that, it now offers unquoted version strings
> which if used as offered then lead to syntax errors.

Ooops.

> The code change seems to have been intentional, but I don't think the
> behavior change was intended.

Given the comments about it, I'm sure I tested the behavior somewhere
along the line --- but I must not have done so with the final logic
of _complete_from_query.

> Putting pg_catalog.quote_ident back
> into Query_for_list_of_available_extension_versions* fixes it, but might
> not be the best way to fix it.

Yeah, that seems like the appropriate fix.  Done, thanks for the report!

            regards, tom lane



pgsql-hackers by date:

Previous
From: Jeff Janes
Date:
Subject: 15beta1 tab completion of extension versions
Next
From: Tom Lane
Date:
Subject: Re: 15beta1 tab completion of extension versions