Re: Optimization issue of branching UNION ALL - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Optimization issue of branching UNION ALL
Date
Msg-id 1800456.1671680935@sss.pgh.pa.us
Whole thread Raw
In response to Re: Optimization issue of branching UNION ALL  (Richard Guo <guofenglinux@gmail.com>)
Responses Re: Optimization issue of branching UNION ALL  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Richard Guo <guofenglinux@gmail.com> writes:
> I noticed we also check 'parse->hasSubLinks' when we fix PHVs and
> AppendRelInfos in pull_up_simple_subquery.  I'm not sure why we have
> this check.  It seems not necessary.

Yeah, I was wondering about that too ... maybe it was important
in some previous state of the code?  I didn't do any archeology
though.

> In remove_result_refs, I don't think we need to check 'lastPHId' again
> before calling substitute_phv_relids, since it has been checked a few
> lines earlier.

Oh, duh ...

            regards, tom lane



pgsql-hackers by date:

Previous
From: Kyotaro Horiguchi
Date:
Subject: Re: Inconsistency in reporting checkpointer stats
Next
From: Tom Lane
Date:
Subject: Re: Optimization issue of branching UNION ALL