On 8 Apr 2026, at 10:31, SATYANARAYANA NARLAPURAM <satyanarlapuram@gmail.com> wrote:
On Fri, Apr 3, 2026 at 8:33 AM Daniel Gustafsson <daniel@yesql.se> wrote:
The attached rebase with a PG_CONTROL_VERSION bump is what I have staged for later tonight, submitting here to have the (hopefully) final patch archived as well as another CFBot run.
Sorry for the late review.
No need to apologise, reviewing already committed features is one of the most
valuable contributions there is. Thank you for looking!
pg_enable/disable_data_checksums() aren't needed to be run
on the standby. It appears the call would silently register a dynamic background worker that
could never start , and could unexpectedly fire after promotion.
I think this is correct, and the right fix. Since I am travelling right now I
am a bit cautious with applying code changes, so I have this one staged for
when I get back. I'll re-review, test and might add a test for it as well when