Re: Patch: Tie stats options to autovacuum in - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Patch: Tie stats options to autovacuum in
Date
Msg-id 17943.1159840454@sss.pgh.pa.us
Whole thread Raw
In response to Re: Patch: Tie stats options to autovacuum in  (Jim Nasby <jim@nasby.net>)
List pgsql-hackers
Jim Nasby <jim@nasby.net> writes:
> On Oct 2, 2006, at 9:17 PM, Bruce Momjian wrote:
>> Jim Nasby wrote:
>>> Hrm... how about if the options are incompatible on HUP we refuse to
>>> pick up any new settings and complain loudly?
>> 
>> We don't read postgresql.conf as a test and then set values.

> IMHO we should... if something got botched in the config file I'd  
> rather have it complain and not change anything instead of taking  
> just some of the changes.

Apparently, neither of you have read the code nor experimented with this
behavior.

The core reason why GUC variables should not be interdependent (as Jim
proposed upthread) is exactly that it would break the ability of
ProcessConfigFile to validate the new settings before applying them.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Jim Nasby
Date:
Subject: Re: Patch: Tie stats options to autovacuum in
Next
From: Bruce Momjian
Date:
Subject: Re: [PATCHES] Bad bug in fopen() wrapper code