Re: C++ keywords in headers (was Re: [GENERAL] #include ) - Mailing list pgsql-hackers

From Tom Lane
Subject Re: C++ keywords in headers (was Re: [GENERAL] #include )
Date
Msg-id 17925.1293473223@sss.pgh.pa.us
Whole thread Raw
In response to Re: C++ keywords in headers (was Re: [GENERAL] #include )  (Magnus Hagander <magnus@hagander.net>)
Responses Re: C++ keywords in headers (was Re: [GENERAL] #include )
List pgsql-hackers
Magnus Hagander <magnus@hagander.net> writes:
> On Mon, Dec 27, 2010 at 18:50, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> src/tools/pginclude/ already contains several scripts for this sort of
>> thing. �Bruce runs them by hand occasionally, although I just found out
>> that he's evidently not run the does-each-header-compile-standalone
>> test in awhile. �It would probably pay to automate these.

> Could this at some point be platform dependent? If so, could it be run
> on the buildfarm?

It's certainly possible that someone could use a C++ keyword in a
platform-specific, or feature-specific, part of an include file.
The current form of this script will only find problems in active
code; so running it on the buildfarm would be indicated if we want
to have real confidence that there are no problems.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Magnus Hagander
Date:
Subject: Re: C++ keywords in headers (was Re: [GENERAL] #include )
Next
From: Tom Lane
Date:
Subject: Re: C++ keywords in headers (was Re: [GENERAL] #include )