Request a Demo
Home   >   mailing lists

Re: Progress reporting: a debug trace and a test framework - Mailing list pgsql-hackers

From Manu
Subject Re: Progress reporting: a debug trace and a test framework
Date
Msg-id 179125014996.802400.13042330481622402940@gmail.com
Whole thread
In response to Re: Add a test for index_rebuild_count of REPACK (CONCURRENTLY)  (Manu <manuelreyesbravo@gmail.com>)
Responses Re: Progress reporting: a debug trace and a test framework
List pgsql-hackers
Tree view 
v4 attached, rebased over master.

While rebasing, the completeness check in 0006 flagged that commit
1378aa13430 ("Report per-index vacuum progress in pg_stat_progress_vacuum")
added PROGRESS_VACUUM_CURRENT_INDEX_RELID without it being described in the
spec that the test reads from progress.h.  v4 classifies it -- it is the
OID of the index a worker is currently processing, so a free value.
Catching that kind of drift, a new counter that nothing describes or
tests, is what the check is for.

Nothing else changed since v3: the four bug fixes in 0001-0004 and the
PROGRESS_DEBUG trace in 0005 are the same.

Regards,
Manu
Attachment

pgsql-hackers by date:

Previous
From: David Rowley
Date:
Subject: Re: stale comment in struct AlteredTableInfo
Next
From: SungJun Jang
Date:
Subject: Re: Remove invalid SS2/SS3 handling from EUC-KR routines