Re: [COMMITTERS] pgsql: Fix multi-column range partitioning constraints. - Mailing list pgsql-committers

From Tom Lane
Subject Re: [COMMITTERS] pgsql: Fix multi-column range partitioning constraints.
Date
Msg-id 17902.1494704764@sss.pgh.pa.us
Whole thread Raw
In response to [COMMITTERS] pgsql: Fix multi-column range partitioning constraints.  (Robert Haas <rhaas@postgresql.org>)
List pgsql-committers
Robert Haas <rhaas@postgresql.org> writes:
> Fix multi-column range partitioning constraints.

Newer gcc versions are not very happy with this:

partition.c: In function 'get_qual_from_partbound':
partition.c:1642:18: warning: 'partexprs_item_saved' may be used uninitialized in this function [-Wmaybe-uninitialized]
   partexprs_item = partexprs_item_saved;
   ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~
partition.c:1500:8: note: 'partexprs_item_saved' was declared here
       *partexprs_item_saved;
        ^~~~~~~~~~~~~~~~~~~~

$ gcc -v
gcc version 6.3.1 20161221 (Red Hat 6.3.1-1) (GCC)

Please fix.

            regards, tom lane


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: [COMMITTERS] pgsql: Redesign get_attstatsslot()/free_attstatsslot() for moresafety
Next
From: Andres Freund
Date:
Subject: [COMMITTERS] pgsql: Fix race condition leading to hanging logical slot creation.