Re: pg_plan_advice: fix empty FOREIGN_JOIN sublist validation - Mailing list pgsql-hackers

From Pierre Forstmann
Subject Re: pg_plan_advice: fix empty FOREIGN_JOIN sublist validation
Date
Msg-id 178723816589.1145.6372890389262859808.pgcf@coridan.postgresql.org
Whole thread
In response to Re: pg_plan_advice: fix empty FOREIGN_JOIN sublist validation  (Chao Li <li.evan.chao@gmail.com>)
List pgsql-hackers
The following review has been posted through the commitfest application:
make installcheck-world:  tested, passed
Implements feature:       tested, passed
Spec compliant:           not tested
Documentation:            not tested

Hello,

I have reviewed this patch and it looks good to me.
I can reproduce the issue in master branch and applying the patch in a specific branch has fixed the issue: new test
caselooks also good to me.
 

I don't think it is needed to check SQL compliance or to update documentation.

Regards
Pierre Forstmann.

The new status of this patch is: Ready for Committer

pgsql-hackers by date:

Previous
From: shveta malik
Date:
Subject: Re: Support EXCEPT for TABLES IN SCHEMA publications
Next
From: "Zhijie Hou (Fujitsu)"
Date:
Subject: RE: Logical replication row filter loses unchanged toasted columns