Re: Unqualified pg_catalog casts in pg_dump - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Unqualified pg_catalog casts in pg_dump
Date
Msg-id 17869.1584982444@sss.pgh.pa.us
Whole thread Raw
In response to Unqualified pg_catalog casts in pg_dump  (Daniel Gustafsson <daniel@yesql.se>)
Responses Re: Unqualified pg_catalog casts in pg_dump  (Daniel Gustafsson <daniel@yesql.se>)
List pgsql-hackers
Daniel Gustafsson <daniel@yesql.se> writes:
> When looking at something different, I happened to notice that pg_dump is a bit
> inconsistent in how it qualifies casts to pg_catalog entities like regclass and
> oid.  Most casts are qualified, but not all.  Even though it functionally is
> the same, being consistent is a good thing IMO and I can't see a reason not to,
> so the attached patch adds qualifications (the unqualified regclass cast in the
> TAP test left on purpose).

While this used to be important before we made pg_dump force a minimal
search_path, I'm not sure that there's any point in being picky about
it anymore.  (psql's describe.c is a different story though.)

            regards, tom lane



pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: weird hash plan cost, starting with pg10
Next
From: Daniel Gustafsson
Date:
Subject: Re: Unqualified pg_catalog casts in pg_dump