Re: Buglets in equivclass.c - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Buglets in equivclass.c
Date
Msg-id 1786355.1601918247@sss.pgh.pa.us
Whole thread Raw
In response to Re: Buglets in equivclass.c  (David Rowley <dgrowleyml@gmail.com>)
List pgsql-hackers
David Rowley <dgrowleyml@gmail.com> writes:
> On Mon, 5 Oct 2020 at 06:29, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> I'm unsure whether to back-patch either of these.  They both seem to be
>> just latent bugs so far as the core code is concerned, but the first one
>> in particular seems like something that could bite extension code.
>> Thoughts?

> That's a good question. I'm leaning towards backpatching both of them.
> The 2nd is new as of v13, so it does not seem unreasonable that
> someone has just not yet stumbled on it with some extension that adds
> extra child ECs. I can imagine a use case for that, by getting rid of
> needless equality quals that duplicate the partition constraint.  The
> fix for the first just seems neater/faster/correct, so I can't really
> see any reason not to backpatch it.

Yeah, that's my conclusion too after sleeping on it.  Pushed,
thanks for reviewing.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Bharath Rupireddy
Date:
Subject: Re: Use standard SIGHUP and SIGTERM handlers in autoprewarm module
Next
From: Bruce Momjian
Date:
Subject: Re: "cert" + clientcert=verify-ca in pg_hba.conf?