Re: pgsql: Move a comment - Mailing list pgsql-committers

From Peter Eisentraut
Subject Re: pgsql: Move a comment
Date
Msg-id 1784be53-3594-6b02-7a8a-8411e2c73e27@enterprisedb.com
Whole thread Raw
In response to Re: pgsql: Move a comment  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
On 09.07.22 17:14, Tom Lane wrote:
> Peter Eisentraut <peter@eisentraut.org> writes:
>> Move a comment from the to-be-deleted section of nodes.h to where it
>> might still be useful.
> 
> Hm.  I'm kind of sad that we lost
> 
> -   /*
> -    * TAGS FOR RANDOM OTHER STUFF
> -    *
> -    * These are objects that aren't part of parse/plan/execute node tree
> -    * structures, but we give them NodeTags anyway for identification
> -    * purposes (usually because they are involved in APIs where we want to
> -    * pass multiple object types through the same pointer).
> -    */
> 
> Not quite sure where that info should be put now.  Maybe nodes/README
> could get another para that explains what types of objects get
> treated as Nodes?

Yeah, I looked at that comment, too, but it seemed that the particular 
node types were already adequately documented at their sites.  But 
nodes/README seems like a good destination in general.




pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Doc: rearrange high-level commentary about node support coverage
Next
From: Tom Lane
Date:
Subject: pgsql: Exclude nodetags.h from headerscheck and cpluspluscheck.